Adding more Add data logos to Icons #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Docker, Kubernetes and Redis logos
formgeist
commented
Jan 29, 2018
| @@ -112,7 +112,6 @@ exports[`EuiCodeEditor is rendered 1`] = ` | |||
| wrap="off" | |||
| /> | |||
| <div | |||
| aria-hidden="true" | |||
There was a problem hiding this comment.
@snide Not sure why these are removed, it happens after I run tests.
formgeist
commented
Jan 29, 2018
| @@ -17,6 +17,7 @@ exports[`EuiFormRow behavior onBlur is called in child 1`] = ` | |||
| <EuiFormLabel | |||
| htmlFor="generated-id" | |||
| isFocused={false} | |||
| isInvalid={undefined} | |||
There was a problem hiding this comment.
@snide Same goes for these, added after tests.
|
You're going to want to clear your cache.
Then rerun the tests. |
|
@snide Right, will do |
|
@snide Odd. The tests pass, but it seems it failed anyways 😟 |
|
Merging. Travis acting up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic/kibana#16279
Adding Docker, Kubernetes and Redis logos to the Icons/Logos list for the Add data UI in Kibana.